Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(runtime): Runtime Tests Framework and Ibc Tests #4164

Closed
wants to merge 1 commit into from

Conversation

kollegian
Copy link
Contributor

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • [X ] I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • [X ] I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@kollegian kollegian added the Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform label Sep 29, 2023
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 13 1h 52m 6
blasrodri 9 18h 45m 6
JafarAz 7 1h 53m 3
kkast 6 7h 26m 14
RustNinja 5 17h 38m 0
mina86 3 8h 14m 1
fl-y 2 6d 7h 11m 0
vmarkushin 1 16h 47m 4

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4164/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4164/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4164/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4164/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4164/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@kollegian kollegian changed the title Runtime Tests Framework and Ibc Tests test(runtime): Runtime Tests Framework and Ibc Tests Sep 29, 2023
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if any code was generated i would prefer it is not pushed to repo.

@blasrodri
Copy link
Contributor

Regarding IBC tests

  • add some multihop transfers (usgin XCM as well)
  • add some failing transfers that have an incorrect memo field and see that they fail, and the user get the funds back
  • are we testing timeouts?

@dzmitry-lahoda
Copy link
Contributor

would be awesome to have one simplest test run on ci. i can help to run it in ci. so if it will be unstable , test should be fixed. after we have one e2e simplest. we can add all others must to be added. we need first to get 80% of test value.

@kollegian
Copy link
Contributor Author

Regarding IBC tests

  • add some multihop transfers (usgin XCM as well)
  • add some failing transfers that have an incorrect memo field and see that they fail, and the user get the funds back
  • are we testing timeouts?

@blasrodri multihop will be in a separate test and I was planning to add memo validation there, and timeouts is a good point, will add here.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Oct 8, 2023
@github-actions
Copy link

close-pr

@github-actions github-actions bot closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform Stale-item bot: Stale PRs and issues handling #owned:terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants