Skip to content

Commit

Permalink
Excluded some dev time assemblies from automated updates
Browse files Browse the repository at this point in the history
  • Loading branch information
stesee committed Jun 4, 2021
1 parent 67f804b commit da0516e
Show file tree
Hide file tree
Showing 6 changed files with 33 additions and 17 deletions.
16 changes: 11 additions & 5 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
# To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates

version: 2
updates:
- package-ecosystem: "nuget" # See documentation for possible values
directory: "/" # Location of package manifests
schedule:
interval: "daily"
ignore:
- dependency-name: "nunit"
- dependency-name: "SonarAnalyzer.CSharp"
- dependency-name: "AngleSharp"
- dependency-name: "Microsoft.NET.Test.Sdk"
- dependency-name: "Microsoft.AspNetCore.Mvc.Testing"
- dependency-name: "Moq"
- dependency-name: "xunit"
- dependency-name: "xunit.runner.visualstudio"
- dependency-name: "MSTest.TestAdapter"
- dependency-name: "MSTest.TestFramework"
2 changes: 1 addition & 1 deletion PdfAValidator/PdfAValidator.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.20.0.28934">
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.23.0.32424">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
12 changes: 11 additions & 1 deletion PdfAValidatorTest/PdfAValidatorTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.IO;
using System.Linq;
using System.Runtime.InteropServices;
using System.Threading;
using System.Threading.Tasks;
using Xunit;

Expand Down Expand Up @@ -178,6 +179,13 @@ public static async Task ShouldBatchValidatePdfsWithoutThrowingException()
[Fact]
public static async Task ShouldThrowExplainableExceptionOnTooLongCommandLineOnWindows()
{
var expectedLocalizedMessage = "The command line is too long.";

if (Thread.CurrentThread.CurrentCulture.Name.StartsWith("de"))
{
expectedLocalizedMessage = "Die Befehlszeile ist zu lang.";
}

if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
return;
Expand All @@ -195,7 +203,7 @@ public static async Task ShouldThrowExplainableExceptionOnTooLongCommandLineOnWi

var actualException = await Assert.ThrowsAsync<VeraPdfException>(() => pdfAValidator.ValidateBatchWithDetailedReportAsync(tooLongFileList, string.Empty));
Assert.Contains("Calling VeraPdf exited with 1 without any output.", actualException.Message);
Assert.Contains("The command line is too long.", actualException.Message);
Assert.Contains(expectedLocalizedMessage, actualException.Message);
}

[Fact]
Expand Down Expand Up @@ -277,7 +285,9 @@ public static async Task ShouldNotFailOnMultipleDisposeCalls()
{
var postscriptValidator = new PdfAValidator();
_ = await postscriptValidator.ValidateAsync("./TestPdfFiles/FromLibreOffice.pdf");
Assert.True(File.Exists(postscriptValidator.VeraPdfStartScript));
postscriptValidator.Dispose();
Assert.False(File.Exists(postscriptValidator.VeraPdfStartScript));
#pragma warning disable S3966 // Expecting multiple dispose calls to pass
postscriptValidator.Dispose();
#pragma warning restore S3966 // Expecting multiple dispose calls to pass
Expand Down
4 changes: 2 additions & 2 deletions PdfAValidatorTest/PdfAValidatorTest.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.1" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.20.0.28934">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.10.0" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.23.0.32424">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
6 changes: 3 additions & 3 deletions PdfAValidatorWebApi/PdfAValidatorWebApi.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@

<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="5.0.2" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.20.0.28934">
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.23.0.32424">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Swashbuckle.AspNetCore" Version="6.1.1" />
<PackageReference Include="Swashbuckle.AspNetCore.Filters" Version="6.1.0" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="6.1.4" />
<PackageReference Include="Swashbuckle.AspNetCore.Filters" Version="7.0.2" />
</ItemGroup>

<ItemGroup>
Expand Down
10 changes: 5 additions & 5 deletions PdfAValidatorWebApiTest/PdfAValidatorWebApiTest.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.1" />
<PackageReference Include="AngleSharp" Version="0.14.0" />
<PackageReference Include="Microsoft.AspNetCore.Identity.UI" Version="5.0.4" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="5.0.4" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.20.0.28934">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.10.0" />
<PackageReference Include="AngleSharp" Version="0.15.0" />
<PackageReference Include="Microsoft.AspNetCore.Identity.UI" Version="5.0.6" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="5.0.6" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.23.0.32424">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down

0 comments on commit da0516e

Please sign in to comment.