feat(pinia-orm)!: Make fields default nullable #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeDredd
added
enhancement
Merged
CodeDredd
added a commit
that referenced
this pull request
Aug 20, 2022
* refactor(pinia-orm)!: code split decorators and helpers (#185) * refactor(pinia-orm): code split decorators and helpers * test: change hook tests * refactor: helpers splitting not yet * test: fix all with new decorators code splitting Moved decorators to `pinia-orm/decorators` and removed them from `pinia-orm` * refactor: linting * docs: update to code splitting BREAKING-CHANGE: Moved decorators to `pinia-orm/decorators` and removed them from `pinia-orm` * build(pinia-orm): move from `normalizr` to `@pinia-orm/normalizr` (#192) * chore(deps): update devdependency eslint to ^8.22.0 (#187) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update devdependency eslint to ^8.22.0 (#186) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * build(normalizr): create own `normalizr` package (#191) * feat(normalizr): First release Reduced version of `normalizr` * chore(normalizr): update deps * chore(normalizr): update deps * chore(normalizr): remove custom release notes for every package * build(pinia-orm): move from `normalizr` to `@pinia-orm/normalizr` * build(normalizr): fix exports * refactor(pinia-orm): update deps * refactor(pinia-orm): fix local packge lock file Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(pinia-orm): improve typings for `piniaOptions`, `useDataStore`, `useStoreActions` and `piniaStore` (#204) * chore(pinia-orm): improve typings for `piniaOptions`, `useDataStore`, `useStoreActions` and `piniaStore` * refactor(pinia-orm): linting * refactor(pinia-orm): change import so other packages can resolve it * refactor(pinia-orm): fix dynamic type import * refactor(pinia-orm): set normalizr to workspace * feat(pinia-orm): add `groupBy` method to query (#213) * feat(pinia-orm): add `groupBy` method to query * chore: fix ci workflow with used local packages * chore: fix ci workflow with used local packages * docs: add documentation for `groupBy` * chore: switch from lerna to lerna-lite for workspace support * chore: add shamefully hoist for now * chore: update ci * chore: add workspace to nuxt package * chore: change nuxt build * chore: change nuxt build to fix ci * chore: change nuxt build to fix ci * chore: change root build to fix ci * chore: change build to fix ci * chore: change build to fix ci * chore: change build to fix ci * chore: update lock * chore: add workspace again * chore: change build back again * feat(pinia-orm)!: Move casts to seperate bundle & create uid packages (#215) * feat(pinia-orm): Move Uid & casts to seperate bundles to import You need now to use `import { ArrayCast } from 'pinia-orm/casts'` for default casts. For Uid there a different separate Casts. The one using `nanoid`, the other `uuid` package. BREAKING-CHANGE: Removed casts by string e.g. `string`. * feat(pinia-orm): Add working uuid & nanoid packages * docs(pinia-orm): Update docs * docs(pinia-orm): Update cast docs * refactor(pinia-orm): linting * chore: update deps * fix(pinia-orm): find a way running it in nuxt2 * fix(pinia-orm): change build so `cjs` files are now `js` - Nuxt 2 somehow doesnt run babel with `cjs` files and therefor features like "nullish coalescing operator" are not working. As a workaround the files are renamed to 'js' - Also fixed the new uid decorators not working correctly - Added an option to pass `pinia` to the store instance to be able to use it outside of `setup` * docs(pinia-orm): Update correctly * docs: fix small typo * feat(pinia-orm): make fields as default nullable (#229) BREAKING-CHANGE: Removed `nullable` and added `notNullable`. Fields are per default now null. * docs: add some install notes Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
vuex-orm/vuex-orm-next#95
Thoughts
It's a good idea to make fields per default null and throw a warning if they are set as
notNullableBREAKING CHANGES: Removed
nullableand addednotNullable. Fields are per default now null.