Adding ipv6 support #1655
Open
Adding ipv6 support #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oalbrigt
requested changes
Jun 2, 2021
| @@ -240,11 +238,21 @@ ec2ip_monitor() { | |||
| for rtb in $(echo $OCF_RESKEY_routing_table | sed -e 's/,/ /g'); do | |||
| ocf_log info "monitor: check routing table (API call) - $rtb" | |||
| if [ -z "${OCF_RESKEY_routing_table_role}" ]; then | |||
| cmd="$OCF_RESKEY_awscli --profile $OCF_RESKEY_profile $region_opt --output text ec2 describe-route-tables --route-table-ids $rtb --query RouteTables[*].Routes[?DestinationCidrBlock=='$OCF_RESKEY_ip/32'].$OCF_RESKEY_lookup_type" | |||
| if [[ "$OCF_RESKEY_ip" == *[:]* ]]; | |||
There was a problem hiding this comment.
You should use case to avoid these bashables.
Example:
resource-agents/heartbeat/exportfs
Lines 283 to 284 in 34e75a5
And also bump the indentation back a tab for this section.
| ocf_log debug "executing command: $cmd" | ||
| ROUTE_TO_INSTANCE="$($cmd)" | ||
| else | ||
| cmd="$OCF_RESKEY_awscli $region_opt --output text ec2 describe-route-tables --route-table-ids $rtb --query RouteTables[*].Routes[?DestinationCidrBlock=='$OCF_RESKEY_ip/32'].$OCF_RESKEY_lookup_type" | ||
| if [[ "$OCF_RESKEY_ip" == *[:]* ]]; |
There was a problem hiding this comment.
This section should also have one less tab to fit match the rest of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I am add ipv6 support to aws-vpc-move-ip shell script. Please see if I did everything correctly, please accept the commit.