[WIP] Remove lio_iblock usage in lio-t implementation of iSCSILogicalUnit #1476
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of backstore index in lio-t implementation.
|
Can one of the admins verify this patch? |
|
This PR seems a bit unambitios when compared with #1072 which would solve the problem too. I'll ask the author whether ho could resolve the conflicts. |
fpiecka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lio_iblock parameter is used in iSCSILogicalUnit_start(), although it is unsupported in lio-t implementation (see iSCSILogicalUnit_validate()).
This PR removes the use of lio_iblock and instead tries to autodetect the backstore index (for lio-t only).
Indexes are assigned sequentially and their value depends on the order in which the backstores are created by targetcli (i.e. on the order in which resources are started).
In current implementation, only 1 LUN resource based on lio-t works (tested in CentOS 8). The second one fails to start as it has a higher index than 0.
I believe this PR should resolve #1256.