Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tickle_tcp implementation #1451

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

New tickle_tcp implementation #1451

wants to merge 3 commits into from

Commits on Jan 23, 2020

  1. Delete existing tickle_tcp implementation 

    Prepare the source tree for adding a new implementation
of the tickle_tcp utility, to fix various issues in the
current implementation, e.g.:
  - Buffer overflow in the parser
  - Write access to datastructures previously declared 'const'
  - Reliance on Linux-only datastructures (struct iphdr)
  - Some unfinished code, dead code or code that executes, but
    has no effect
    (e.g. close on exec, but the utility never executes anything)
  - Some less important issues, like reinterpretation of parsed
    negative numbers as positive numbers, due to the loose
    parsing provided by the strtoul function
    @raltnoeder
    raltnoeder committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    afafc17 View commit details
    Browse the repository at this point in the history

  2. Add new tickle_tcp implementation 

    This commit replaces the previous implementation of tickle_tcp
with a new implementation.
Apart from fixing various problems of the previous implementation,
the new implementation adds support for link-local IPv6 addresses
which was incomplete in the previous implementation (although
that does not seem really useful anyway), and it has a more
whitespace-tolerant parser.

This implementation should also be more portable than the
previous one, which relied on Linux-specific data structures.
    @raltnoeder
    raltnoeder committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    4ac59b8 View commit details
    Browse the repository at this point in the history

  3. Modify Makefile.am for new tickle_tcp implementation 

    The new tickle_tcp implementation requires compilation
in C99 (or newer) mode.
    @raltnoeder
    raltnoeder committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    5997987 View commit details
    Browse the repository at this point in the history