Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fence_vmware_soap.py #556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mpetricone
Copy link

Detailed error message on VM shutdown failure. The original value, "EC_WAITING_OFF" alone can be misleading.

Detailed error messages on VM shutdown failure.
@knet-jenkins
Copy link

knet-jenkins bot commented Aug 27, 2023

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-556/1/input

@@ -204,6 +204,7 @@ def set_power_status(conn, options):
if options["--action"] == "on":
fail(EC_WAITING_ON)
else:
print(ex)
Copy link
Collaborator

@oalbrigt oalbrigt Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use logging.debug():
https://github.com/ClusterLabs/fence-agents/blob/main/doc/fa-dev-guide.md#logging-and-failing

That way it will only give you the exception info when you use -v/--verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants