Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a segfault + related refactoring #50

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Sep 13, 2016

  1. Low: make find_site_by_name failure set error code

    At one instance (query_get_string_answer) it just flips the sign as it
    is customary to return negative value upon error (for uniform
    treatment).
    jnpkrn committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    5b8a336 View commit details
    Browse the repository at this point in the history
  2. High: ensure local site resolved for all effective actions

    Previously, running:
    
      touch /etc/booth/booth.conf
      booth grant a_ticket
    
    would result in a segfault due to not guarding resolution of local
    site properly in some circumstances, so do it at the central place.
    Also error messaging is now centralized.
    jnpkrn committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    bcf1117 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1185487 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2016

  1. Refactor: call find_site_by_name just once, up the stream

    Respective logic was duplicated for all "booth list/peers/grant/revoke"
    and "geostore list/get/set/del" separately, so utilize a natural control
    flow to carry this once-resolved target site from here, sharing it with
    the special case of "daemon" role invoked with "-s site" (debug mode).
    Side effect: simpler, terser code.
    jnpkrn committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    0c94ea1 View commit details
    Browse the repository at this point in the history