Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include surface elevation in initialization of land surface temp #898

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

akshaysridhar
Copy link
Member

@akshaysridhar akshaysridhar commented Jul 16, 2024

Fetch atmos surface elevation for use in land surface temperature initialization.

bucket.T surface values
Updated_T_Field

@szy21
Copy link
Member

szy21 commented Oct 1, 2024

Could we update this PR and get it in? I think we should change this as it will result in more physical initial conditions.

Copy link
Member Author

@akshaysridhar akshaysridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert changes to temp_anomaly

experiments/ClimaEarth/run_amip.jl Outdated Show resolved Hide resolved
experiments/ClimaEarth/components/land/climaland_bucket.jl Outdated Show resolved Hide resolved
experiments/ClimaEarth/run_amip.jl Outdated Show resolved Hide resolved
experiments/ClimaEarth/run_amip.jl Outdated Show resolved Hide resolved
@akshaysridhar akshaysridhar force-pushed the as/sfc-temp branch 2 times, most recently from 77ad1f8 to 2a4754b Compare October 2, 2024 18:30
@akshaysridhar
Copy link
Member Author

@juliasloan25 I've minimised use of parent, and moved the surface modifications to the land bucket file.

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Akshay! After removing the last comment this is good to merge

experiments/ClimaEarth/run_amip.jl Outdated Show resolved Hide resolved
@akshaysridhar akshaysridhar force-pushed the as/sfc-temp branch 2 times, most recently from 68ee326 to f57aa05 Compare October 2, 2024 19:31
	modified:   experiments/ClimaEarth/run_amip.jl
	modified:   run_cloudy_slabplanet.jl
@akshaysridhar akshaysridhar merged commit 182cb00 into main Oct 2, 2024
6 checks passed
@akshaysridhar akshaysridhar deleted the as/sfc-temp branch October 2, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants