Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output diagnostics when simulation is less than 1h #3337

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

Sbozzolo
Copy link
Member

There's no point in adding hourly diagnostics when the simulation is less than 1h

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thought - this function taking in only t_end implies that t_start = 0. Maybe it should take in the simulation length instead

@Sbozzolo
Copy link
Member Author

Looks good, just one thought - this function taking in only t_end implies that t_start = 0. Maybe it should take in the simulation length instead

Changed to use duration instead.

@Sbozzolo Sbozzolo added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@Sbozzolo Sbozzolo added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 1fecdfa Sep 27, 2024
14 of 16 checks passed
@Sbozzolo Sbozzolo deleted the gb/diagnostics branch September 27, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants