Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX2.0] Add Other Profile Parcels #305

Merged
merged 8 commits into from
Aug 29, 2024
Merged

[UX2.0] Add Other Profile Parcels #305

merged 8 commits into from
Aug 29, 2024

Conversation

seconroy
Copy link
Collaborator

Description

Adds the following Profile Parcel resources and data sources:

  • Other Feature Profile
  • Other USCE
  • Other ThousandEyes

Types of Changes

  • New feature (non-breaking change which adds functionaality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/CI change
  • Code quality improvement/refactoring/documentation (no functional changes)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests pass locally

@seconroy seconroy requested a review from danischm August 26, 2024 11:31
@danischm danischm requested a review from tzarski0 August 27, 2024 15:22
tzarski0
tzarski0 requested changes Aug 28, 2024
View reviewed changes
gen/definitions/profile_parcels/other_ucse.yaml Outdated Show resolved Hide resolved
gen/definitions/profile_parcels/other_ucse.yaml Show resolved Hide resolved
gen/definitions/profile_parcels/other_ucse.yaml Outdated Show resolved Hide resolved
gen/definitions/profile_parcels/other_ucse.yaml Outdated Show resolved Hide resolved
@danischm danischm merged commit 064fe7e into CiscoDevNet:main Aug 29, 2024
1 check failed
@danischm danischm deleted the other-profile-parcels branch August 29, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarski0 tzarski0 tzarski0 requested changes

@danischm danischm Awaiting requested review from danischm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seconroy @tzarski0 @danischm