Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX2.0] Adds Missing Tracker & Tracker Group Profile Parcels #293

Merged
merged 11 commits into from
Aug 23, 2024
Merged

[UX2.0] Adds Missing Tracker & Tracker Group Profile Parcels #293

merged 11 commits into from
Aug 23, 2024

Conversation

seconroy
Copy link
Collaborator

@seconroy seconroy commented Jul 17, 2024 •
edited
Loading

Description

Adds the following Profile Parcel resources and data sources:

  • Transport Tracker
  • Service Tracker Group
  • Transport IPv6 Tracker Group
  • Transport Tracker Group
  • Service Object Tracker
  • Service Object Tracker Group

Additionally, Adds exclude_minimum_test for when the all and minimum tests are the same. Also, adds the secondary_test_value for test that require more than one test value.

Types of Changes

  • New feature (non-breaking change which adds functionaality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/CI change
  • Code quality improvement/refactoring/documentation (no functional changes)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests pass locally

@seconroy seconroy marked this pull request as ready for review August 12, 2024 12:23
@seconroy seconroy changed the title [UX2.0] Adds Transport Tracker & Tracker Group Profile Parcel [UX2.0] Adds Missing Tracker & Tracker Group Profile Parcels Aug 22, 2024
danischm
danischm requested changes Aug 23, 2024
View reviewed changes
gen/schema/schema.yaml Outdated Show resolved Hide resolved
gen/templates/profile_parcels/resource_test.go Outdated Show resolved Hide resolved
internal/provider/log.json Outdated Show resolved Hide resolved
log.json Outdated Show resolved Hide resolved
@danischm danischm merged commit 6e1c88e into CiscoDevNet:main Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarski0 tzarski0 tzarski0 requested changes

@danischm danischm danischm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seconroy @danischm @tzarski0