Cleanup vedge inventory attributes and fix tests

CiscoDevNet · Oct 18, 2023 · f530a6e · f530a6e
1 parent 9b66b02
commit f530a6e
Show file tree

Hide file tree

Showing 64 changed files with 37 additions and 134 deletions.
diff --git a/docs/data-sources/device.md b/docs/data-sources/device.md
@@ -14,8 +14,8 @@ This data source can read the Device .
 
 ```terraform
 data "sdwan_device" "example" {
-  serial_number = "2AJC9DJ"
-  name          = "va-001"
+  serial_number = "EE16A1C0BAD74974AF666E446F15605F"
+  name          = "vsmart"
 }
 ```
 

diff --git a/docs/data-sources/vedge_inventory.md b/docs/data-sources/vedge_inventory.md
@@ -24,7 +24,6 @@ data "sdwan_vedge_inventory" "example" {
 
 - `devices` (Attributes List) List of returned devices (see [below for nested schema](#nestedatt--devices))
 - `id` (String) The id of the object
-- `name` (String) The hostname of a device
 
 <a id="nestedatt--devices"></a>
 ### Nested Schema for `devices`

diff --git a/examples/data-sources/sdwan_device/data-source.tf b/examples/data-sources/sdwan_device/data-source.tf
@@ -1,4 +1,4 @@
 data "sdwan_device" "example" {
-  serial_number = "2AJC9DJ"
-  name          = "va-001"
+  serial_number = "EE16A1C0BAD74974AF666E446F15605F"
+  name          = "vsmart"
 }
diff --git a/gen/definitions/generic/device.yaml b/gen/definitions/generic/device.yaml
@@ -9,14 +9,14 @@ attributes:
     tf_name: serial_number
     type: String
     description: Serial number for device. Could be board or virtual identifier
-    example: 2AJC9DJ
+    example: EE16A1C0BAD74974AF666E446F15605F
     query_param: true
   - model_name: host-name
     tf_name: name
     type: String
     query_param: true
     description: The hostname of a device
-    example: va-001
+    example: vsmart
   - model_name: data
     tf_name: devices
     type: List
@@ -25,28 +25,28 @@ attributes:
       - model_name: deviceId
         type: String
         tf_name: device_id
-        example: 2081c2f4-3f9f-4fee-8078-dcc8904e368d
+        example: 10.0.0.14
         description: The device ID as defined in vManage
       - model_name: uuid
         type: String
         description: Unique identifier for device
         id: true
-        example: 2081c2f4-3f9f-4fee-8078-dcc8904e368d
+        example: cd4aa06a-dee3-43c5-bb95-2a1b29cb86e2
       - model_name: site-id
         tf_name: site_id
         type: String
         description: Site id for respective device
-        example: 400
+        example: 1
       - model_name: board-serial
         tf_name: serial_number
         type: String
         description: Serial number for device. Could be board or virtual identifier
-        example: 2AJC9DJ
+        example: EE16A1C0BAD74974AF666E446F15605F
       - model_name: host-name
         tf_name: hostname
         type: String
         description: Hostname for respective device
-        example: vEdge-123
+        example: vsmart
       - model_name: reachability
         type: String
         description: Reachability of device

diff --git a/gen/definitions/generic/vedge_inventory.yaml b/gen/definitions/generic/vedge_inventory.yaml
@@ -5,11 +5,6 @@ doc_category: Inventory
 remove_id: true
 skip_templates: ["resource.go", "resource_test.go", "resource.tf", "import.sh"]
 attributes:
-  - model_name: host-name
-    tf_name: name
-    type: String
-    description: The hostname of a device
-    example: va-001
   - model_name: data
     tf_name: devices
     type: List
@@ -20,26 +15,29 @@ attributes:
         type: String
         description: Chassis Number
         id: true
-        example: 2081c2f4-3f9f-4fee-8078-dcc8904e368d
+        example: ISR-7C260167-7A6C-628A-00A6-A30214119017
       - model_name: site-id
         tf_name: site_id
         type: String
         description: Site id for respective device
-        example: 400
+        example: 1
+        exclude_test: true
       - model_name: serialNumber
         tf_name: serial_number
         type: String
         description: Serial number for device. Could be board or virtual identifier
-        example: 2AJC9DJ
+        example: d4da6eb56aca4a5a884688ed25abcaed
       - model_name: host-name
         tf_name: hostname
         type: String
         description: Hostname for respective device
-        example: vEdge-123
+        example: router1
+        exclude_test: true
       - model_name: validity
         type: String
         description: Validity of device
         example: valid
+        exclude_test: true
       - model_name: deviceType
         tf_name: device_type
         type: String

diff --git a/gen/templates/generic/data_source_test.go b/gen/templates/generic/data_source_test.go
diff --git a/internal/provider/data_source_sdwan_acl_policy_definition_test.go b/internal/provider/data_source_sdwan_acl_policy_definition_test.go
diff --git a/internal/provider/data_source_sdwan_advanced_inspection_profile_policy_definition_test.go b/internal/provider/data_source_sdwan_advanced_inspection_profile_policy_definition_test.go
diff --git a/internal/provider/data_source_sdwan_advanced_malware_protection_policy_definition_test.go b/internal/provider/data_source_sdwan_advanced_malware_protection_policy_definition_test.go
diff --git a/internal/provider/data_source_sdwan_allow_url_list_policy_object_test.go b/internal/provider/data_source_sdwan_allow_url_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_app_probe_class_policy_object_test.go b/internal/provider/data_source_sdwan_app_probe_class_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_application_aware_routing_policy_definition_test.go b/internal/provider/data_source_sdwan_application_aware_routing_policy_definition_test.go
diff --git a/internal/provider/data_source_sdwan_application_list_policy_object_test.go b/internal/provider/data_source_sdwan_application_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_as_path_list_policy_object_test.go b/internal/provider/data_source_sdwan_as_path_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_block_url_list_policy_object_test.go b/internal/provider/data_source_sdwan_block_url_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_centralized_policy_test.go b/internal/provider/data_source_sdwan_centralized_policy_test.go
diff --git a/internal/provider/data_source_sdwan_cflowd_policy_definition_test.go b/internal/provider/data_source_sdwan_cflowd_policy_definition_test.go
diff --git a/internal/provider/data_source_sdwan_class_map_policy_object_test.go b/internal/provider/data_source_sdwan_class_map_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_cli_device_template_test.go b/internal/provider/data_source_sdwan_cli_device_template_test.go
diff --git a/internal/provider/data_source_sdwan_color_list_policy_object_test.go b/internal/provider/data_source_sdwan_color_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_custom_control_topology_policy_definition_test.go b/internal/provider/data_source_sdwan_custom_control_topology_policy_definition_test.go
diff --git a/internal/provider/data_source_sdwan_data_fqdn_prefix_list_policy_object_test.go b/internal/provider/data_source_sdwan_data_fqdn_prefix_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_data_ipv4_prefix_list_policy_object_test.go b/internal/provider/data_source_sdwan_data_ipv4_prefix_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_data_ipv6_prefix_list_policy_object_test.go b/internal/provider/data_source_sdwan_data_ipv6_prefix_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_device_acl_policy_definition_test.go b/internal/provider/data_source_sdwan_device_acl_policy_definition_test.go
diff --git a/internal/provider/data_source_sdwan_device_test.go b/internal/provider/data_source_sdwan_device_test.go
diff --git a/internal/provider/data_source_sdwan_domain_list_policy_object_test.go b/internal/provider/data_source_sdwan_domain_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_expanded_community_list_policy_object_test.go b/internal/provider/data_source_sdwan_expanded_community_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_extended_community_list_policy_object_test.go b/internal/provider/data_source_sdwan_extended_community_list_policy_object_test.go
diff --git a/internal/provider/data_source_sdwan_feature_device_template_test.go b/internal/provider/data_source_sdwan_feature_device_template_test.go
diff --git a/internal/provider/data_source_sdwan_geo_location_list_policy_object_test.go b/internal/provider/data_source_sdwan_geo_location_list_policy_object_test.go