Refactor hub and spoke topology policy definition

CiscoDevNet · Jul 23, 2023 · 594598b · 594598b
1 parent 4b6c4c2
commit 594598b
Show file tree

Hide file tree

Showing 9 changed files with 138 additions and 136 deletions.
diff --git a/docs/data-sources/hub_and_spoke_topology_policy_definition.md b/docs/data-sources/hub_and_spoke_topology_policy_definition.md
@@ -3,12 +3,12 @@
 page_title: "sdwan_hub_and_spoke_topology_policy_definition Data Source - terraform-provider-sdwan"
 subcategory: "Centralized Policies"
 description: |-
-  This data source can read the Hub and Spoke Topology policy definition.
+  This data source can read the Hub and Spoke Topology Policy Definition .
 ---
 
 # sdwan_hub_and_spoke_topology_policy_definition (Data Source)
 
-This data source can read the Hub and Spoke Topology policy definition.
+This data source can read the Hub and Spoke Topology Policy Definition .
 
 ## Example Usage
 
@@ -23,15 +23,14 @@ data "sdwan_hub_and_spoke_topology_policy_definition" "example" {
 
 ### Required
 
-- `id` (String) The id of the policy definition
+- `id` (String) The id of the object
 
 ### Read-Only
 
 - `description` (String) The description of the policy definition
 - `name` (String) The name of the policy definition
 - `topologies` (Attributes List) List of topologies (see [below for nested schema](#nestedatt--topologies))
-- `type` (String) The policy definition type
-- `version` (Number) The version of the policy definition
+- `version` (Number) The version of the object
 - `vpn_list_id` (String) VPN list ID
 - `vpn_list_version` (Number) VPN list version
 

diff --git a/docs/resources/hub_and_spoke_topology_policy_definition.md b/docs/resources/hub_and_spoke_topology_policy_definition.md
@@ -3,12 +3,12 @@
 page_title: "sdwan_hub_and_spoke_topology_policy_definition Resource - terraform-provider-sdwan"
 subcategory: "Centralized Policies"
 description: |-
-  This resource can manage a Hub and Spoke Topology policy definition.
+  This resource can manage a Hub and Spoke Topology Policy Definition .
 ---
 
 # sdwan_hub_and_spoke_topology_policy_definition (Resource)
 
-This resource can manage a Hub and Spoke Topology policy definition.
+This resource can manage a Hub and Spoke Topology Policy Definition .
 
 ## Example Usage
 
@@ -51,9 +51,8 @@ resource "sdwan_hub_and_spoke_topology_policy_definition" "example" {
 
 ### Read-Only
 
-- `id` (String) The id of the policy definition
-- `type` (String) The policy defintion type
-- `version` (Number) The version of the policy definition
+- `id` (String) The id of the object
+- `version` (Number) The version of the object
 
 <a id="nestedatt--topologies"></a>
 ### Nested Schema for `topologies`

diff --git a/...y_definitions/hub_and_spoke_topology.yaml → ...and_spoke_topology_policy_definition.yaml b/...y_definitions/hub_and_spoke_topology.yaml → ...and_spoke_topology_policy_definition.yaml
@@ -1,21 +1,38 @@
 ---
-name: Hub and Spoke Topology
-type: hubAndSpoke
+name: Hub and Spoke Topology Policy Definition
+rest_endpoint: /template/policy/definition/hubandspoke/
+has_version: true
+id_attribute: definitionId
 root_element: definition
 doc_category: Centralized Policies
-skip_templates: [model.go, resource.go, data_source.go]
 attributes:
+  - model_name: type
+    value: hubAndSpoke
+  - model_name: name
+    tf_name: name
+    type: String
+    mandatory: true
+    description: The name of the policy definition
+    example: Example
+  - model_name: description
+    tf_name: description
+    type: String
+    mandatory: true
+    description: The description of the policy definition
+    example: My description
   - model_name: vpnList
+    data_path: [definition]
     tf_name: vpn_list_id
     type: String
     description: VPN list ID
     example: 04fcbb0b-efbf-43d2-a04b-847d3a7b104e
   - tf_name: vpn_list_version
     tf_only: true
-    type: Int64
+    type: Version
     description: VPN list version
     exclude_test: true
   - model_name: subDefinitions
+    data_path: [definition]
     tf_name: topologies
     type: List
     mandatory: true
@@ -24,6 +41,7 @@ attributes:
       - model_name: name
         tf_name: name
         type: String
+        id: true
         mandatory: true
         description: Topology name
         example: Topology1
@@ -35,11 +53,12 @@ attributes:
           - model_name: siteList
             tf_name: site_list_id
             type: String
+            id: true
             description: Site list ID
             example: e858e1c4-6aa8-4de7-99df-c3adbf80290d
           - tf_name: site_list_version
             tf_only: true
-            type: Int64
+            type: Version
             description: Site list version
             exclude_test: true
           - model_name: hubs
@@ -50,10 +69,11 @@ attributes:
               - model_name: siteList
                 tf_name: site_list_id
                 type: String
+                id: true
                 description: Site list ID
                 example: e858e1c4-6aa8-4de7-99df-c3adbf80290d
               - tf_name: site_list_version
                 tf_only: true
-                type: Int64
+                type: Version
                 description: Site list version
                 exclude_test: true
diff --git a/internal/provider/data_source_sdwan_hub_and_spoke_topology_policy_definition.go b/internal/provider/data_source_sdwan_hub_and_spoke_topology_policy_definition.go
diff --git a/internal/provider/data_source_sdwan_hub_and_spoke_topology_policy_definition_test.go b/internal/provider/data_source_sdwan_hub_and_spoke_topology_policy_definition_test.go