Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_changes] Added new module ndo_mac_sec_policy (DCNE-177 DCNE-74) #522

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[minor_changes] Added new module ndo_mac_sec_policy (DCNE-177 DCNE-74) #522

wants to merge 9 commits into from
+867 −0

Conversation

anvitha-jain
Copy link
Collaborator

@anvitha-jain anvitha-jain commented Aug 22, 2024 •
edited by samiib
Loading

(for macsecPolicies object).
Part of issue #465

@anvitha-jain anvitha-jain added enhancement New feature or request jira-sync Sync this issue to Jira labels Aug 22, 2024
@anvitha-jain anvitha-jain self-assigned this Aug 22, 2024
akinross
akinross requested changes Sep 10, 2024
View reviewed changes
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
tests/integration/targets/ndo_mac_sec_policy/tasks/main.yml Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.98601% with 123 lines in your changes missing coverage. Please review.

Project coverage is 18.55%. Comparing base (55159d6) to head (0eebde7).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
plugins/modules/ndo_mac_sec_policy.py 12.68% 117 Missing ⚠️
plugins/module_utils/mso.py 14.28% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (55159d6) and HEAD (0eebde7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (55159d6) HEAD (0eebde7)
integration 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #522       +/-   ##
===========================================
- Coverage   67.72%   18.55%   -49.17%     
===========================================
  Files          85       86        +1     
  Lines        7644     7787      +143     
  Branches     1982     2020       +38     
===========================================
- Hits         5177     1445     -3732     
- Misses       2099     6341     +4242     
+ Partials      368        1      -367
Flag Coverage Δ
integration ?
sanity 18.55% <13.98%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot changed the title [minor_changes] Added new module ndo_mac_sec_policy [minor_changes] Added new module ndo_mac_sec_policy (DCNE-177) Sep 13, 2024
samiib
samiib requested changes Sep 17, 2024
View reviewed changes
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
samiib
samiib previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross requested changes Sep 19, 2024
View reviewed changes
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
akinross
akinross requested changes Sep 19, 2024
View reviewed changes
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
gmicol
gmicol previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvitha-jain anvitha-jain dismissed stale reviews from gmicol, shrsr, samiib, and sajagana via 3b42b45 October 8, 2024 02:41
akinross
akinross previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmicol
gmicol previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/module_utils/mso.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
lhercot
lhercot requested changes Oct 9, 2024
View reviewed changes
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain dismissed stale reviews from shrsr, gmicol, sajagana, and akinross via a97dba4 October 9, 2024 21:46
samiib
samiib approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiib samiib samiib approved these changes

@shrsr shrsr Awaiting requested review from shrsr

@akinross akinross Awaiting requested review from akinross

@sajagana sajagana Awaiting requested review from sajagana

@gmicol gmicol Awaiting requested review from gmicol

@lhercot lhercot Awaiting requested review from lhercot

Requested changes must be addressed to merge this pull request.

Assignees

@anvitha-jain anvitha-jain

Labels
enhancement New feature or request jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anvitha-jain @lhercot @shrsr @akinross @sajagana @samiib @gmicol