Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-768: Add Spray Can tool #98

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

Lenkomotive
Copy link
Contributor

@Lenkomotive Lenkomotive commented Oct 3, 2024

PAINTROID-768

New Features and Enhancements

  • Implementation of spray tool + a radius slider where the radius of the spray tool can be altered.
  • Unit testing
  • Integration testing
  • extending integration test methods

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Add the link to the ticket in Jira in the description of the PR
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines (Wiki)
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Add new information to the Wiki

@Lenkomotive Lenkomotive marked this pull request as draft October 3, 2024 10:47
@Lenkomotive Lenkomotive requested a review from bakicelebi October 3, 2024 10:47
@Lenkomotive Lenkomotive marked this pull request as ready for review October 3, 2024 15:35
Copy link

@celebi-liebrecht-haas celebi-liebrecht-haas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool seems to create centerly densed points. It can probably we evened out with adjustions to point calculation logic.

test/integration/spray_tool_test.dart Show resolved Hide resolved
@Lenkomotive Lenkomotive changed the title Paintroid 768 PAINTROID-768: Add Spray Can tool Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants