Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paintroid-450 : Add share menu option in paint view #49

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

vishad-tyagi
Copy link
Contributor

@vishad-tyagi vishad-tyagi commented Feb 28, 2024

Ticket
https://catrobat.atlassian.net/browse/PAINTROID-450
Paintroid-450 : Add share menu option in paint view

Description
Add "share" option to the paint view overflow menu.
This should open the phone native share window.

New Features and Enhancements

  • New Features and Enhancements

Refactorings and Bug Fixes

  • Refactorings and Bug Fixes

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

Copy link
Contributor

@Lenkomotive Lenkomotive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The share package seems to be deprecated see here. Please always check if packages are maintained before adding them.

Also- add tests please :)

@vishad-tyagi
Copy link
Contributor Author

@Lenkomotive I have changed the package to share_plus. and have added the tests also. while Native share windows cannot be tested in Flutter widget tests because these tests run in a Dart VM, that does not interact with native components. I have implemented a workaround of checking the entire widget tree before and after, looking for any unexpected behaviour and error dialog. If anything else needs to be changed let me know.
I will be careful in checking the package version from next time 😅

Copy link
Contributor

@msesko msesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check my comments. thanks

@vishad-tyagi vishad-tyagi requested a review from msesko April 21, 2024 08:19
@juliajulie95
Copy link
Contributor

Thank you for the PR!
Please make sure the actual image that was drawn is shared with the share button, not just a text! :)

@juliajulie95 juliajulie95 marked this pull request as draft April 23, 2024 15:56
@vishad-tyagi
Copy link
Contributor Author

@juliajulie95 I intended to do the same initially only but was waiting for additional info like the default format of shared images, whether manual image compression is required or not etc 🙂 , I tried to get more info on the Jira ticket only. So I ended up placing a text-only
Just let me know this info, I will get to work in some time (My uni end sem exams are going on 😅)

@juliajulie95
Copy link
Contributor

Sorry for that.
Please share the currently displayed image. You might have to save it as a temp and then share that file

@vishad-tyagi vishad-tyagi marked this pull request as ready for review June 26, 2024 15:56
@bhav-khurana
Copy link
Contributor

Are we still working on this ticket? @juliajulie95 @msesko
I can complete it if anything is pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants