Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARE-573 Replace 'program' with 'project' in DB & test #4705

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

greilberger13
Copy link
Contributor

@greilberger13 greilberger13 commented Jan 24, 2024

Changes the folders src/db, migrations and test. Now only the routing has to be done.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing (CI), if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer
  • Check that your pull request has been successfully deployed to https://web-test-1.catrob.at/

Additional Description

TODO: Add additional information that is not in your commit-message here

Tests - additional information

TODO: add additional information about testruns here

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 353 lines in your changes are missing coverage. Please review.

Comparison is base (b357ca7) 48.57% compared to head (5dcd645) 47.49%.
Report is 11 commits behind head on develop.

Files Patch % Lines
.../DB/EntityRepository/Project/ProjectRepository.php 25.00% 24 Missing ⚠️
...EntityRepository/Project/ProjectLikeRepository.php 4.16% 23 Missing ⚠️
...cation/Controller/User/NotificationsController.php 0.00% 21 Missing ⚠️
...pository/Project/ScratchProjectRemixRepository.php 43.33% 17 Missing ⚠️
src/Project/ProjectManager.php 62.16% 14 Missing ⚠️
src/Admin/SpecialProjects/FeaturedProjectAdmin.php 0.00% 11 Missing ⚠️
...c/Admin/Users/ReportedUsers/ReportedUsersAdmin.php 0.00% 10 Missing ⚠️
src/DB/Entity/Project/Extension.php 9.09% 10 Missing ⚠️
...ntityRepository/Project/ProjectRemixRepository.php 75.00% 10 Missing ⚠️
src/Project/Remix/RemixManager.php 65.51% 10 Missing ⚠️
... and 66 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #4705      +/-   ##
=============================================
- Coverage      48.57%   47.49%   -1.08%     
  Complexity      5926     5926              
=============================================
  Files            669      669              
  Lines          21310    21310              
=============================================
- Hits           10351    10122     -229     
- Misses         10959    11188     +229     
Flag Coverage Δ
behat 45.03% <52.92%> (-1.11%) ⬇️
phpunit 8.39% <4.12%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greilberger13 greilberger13 force-pushed the SHARE-573 branch 3 times, most recently from 8c38bff to 60c6173 Compare January 24, 2024 16:56
@dmetzner dmetzner marked this pull request as draft January 29, 2024 12:21
@dmetzner
Copy link
Collaborator

@greilberger13
Copy link
Contributor Author

greilberger13 commented Jan 29, 2024

Should the migrations folder even be changed????
Does someone has an idea, what's the problem here?
It has to be with the database as I can see.

@dmetzner
Copy link
Collaborator

Look into: https://mariadb.com/kb/en/rename-table/
And also to reduce the overhead of all our legacy migrations I've "squashed" them: #4984

@dmetzner dmetzner force-pushed the develop branch 14 times, most recently from dc968e3 to a853379 Compare August 6, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants