Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE-271 Typographic hierarchy should be visible #5047

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

IDE-271 Typographic hierarchy should be visible #5047

wants to merge 1 commit into from

Conversation

Frajhamster
Copy link
Contributor

@Frajhamster Frajhamster commented Nov 3, 2024 •
edited
Loading

Jira ticket: https://catrobat.atlassian.net/browse/IDE-271

Description:

  • Improved backpack menus UI

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

JayTropper
JayTropper requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@JayTropper JayTropper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the header to Copyright (C) 2010-2024 The Catrobat Team in every file where the year is not 2024 and remove the merge commit you did. If you need help with GIT you can just text me.

...rc/main/java/org/catrobat/catroid/ui/recyclerview/backpack/BackpackRecyclerViewFragment.java Outdated Show resolved Hide resolved
catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/fragment/RecyclerViewFragment.java Outdated Show resolved Hide resolved
catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/fragment/ScriptFragment.java Outdated Show resolved Hide resolved
@Frajhamster Frajhamster force-pushed the IDE-271 branch 2 times, most recently from d19cd6a to 3421549 Compare November 28, 2024 00:05
JayTropper
JayTropper approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@JayTropper JayTropper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Frajhamster
IDE-271 Improved backpack UI
55ff0f2 
IDE-271 Fix copyright and warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayTropper JayTropper JayTropper approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frajhamster @JayTropper