Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better heuristic for culling fluid top planes in caves #2935

Open
muzikbike opened this issue Dec 15, 2024 · 0 comments · May be fixed by #2931
Open

Better heuristic for culling fluid top planes in caves #2935

muzikbike opened this issue Dec 15, 2024 · 0 comments · May be fixed by #2931
Labels
A-vanilla-issue Area: Vanilla issue T-enhancement Type: Enhancement

Comments

@muzikbike
Copy link
Contributor

Request Description

This is a requirement if we plan on fixing #2470 at all.

Currently, for a given fluid block at elevation y in the world, the game will check if the block at y+1 and the eight blocks in its Moore neighbourhood are all solid (or contain the same fluid); if so, the interior top face is culled. If not, the face is rendered. This works fine for the most part, but causes oddities in some reasonably common situations.

My preferred solution would be the change proposed in #2472, although it has been stated that such a change may introduce other issues, so a different solution may be required; this will need to be discussed.

For cases like the following, the 16 faces underneath the stone blocks would preferably get culled; whether this also happens to the nine in the middle is a perhaps more controversial issue I may explain in a future report.
2024-12-15_15 50 07

@muzikbike muzikbike added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels Dec 15, 2024
@jellysquid3 jellysquid3 added A-vanilla-issue Area: Vanilla issue and removed S-needs-triage Status: Needs triage labels Dec 17, 2024
@douira douira linked a pull request Dec 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vanilla-issue Area: Vanilla issue T-enhancement Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants