Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering inner fluid faces against blocks should be consistent directionally #2947

Open
muzikbike opened this issue Dec 21, 2024 · 0 comments · May be fixed by #2931
Open

Rendering inner fluid faces against blocks should be consistent directionally #2947

muzikbike opened this issue Dec 21, 2024 · 0 comments · May be fixed by #2931
Labels
A-vanilla-issue Area: Vanilla issue T-enhancement Type: Enhancement

Comments

@muzikbike
Copy link
Contributor

Request Description

Relates to #2935.

For solid blocks, the inner faces of fluids typically are not rendered.
Image

There are, however, exceptions such as glass: while the top and four side faces will not have the fluid render against them, the bottom face will. This is inconsistent with many opaque blocks.
Image
Image

The behaviour should ideally be consistent: either fluid faces wouldn't render against any of glass's faces, or they should render against all of them. The former behaviour appears to be preferable.

Solving this issue seems tricky, however, without special-casing certain block IDs or introducing behaviour with the potential of causing equivalent or larger incongruences.

@muzikbike muzikbike added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels Dec 21, 2024
@jellysquid3 jellysquid3 added A-vanilla-issue Area: Vanilla issue and removed S-needs-triage Status: Needs triage labels Dec 21, 2024
@douira douira linked a pull request Dec 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vanilla-issue Area: Vanilla issue T-enhancement Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants