Store outages in Outages.yaml #6
Conversation
|
@larsks did a proof of concept here that would be both human-friendly and tooling friendly. |
There was a problem hiding this comment.
I think I would either merge these models into models.py, or I would rename models.py to models/rates.py and make this models/outages.py, and then have models/__init__.py import all the models.
| end: datetime | ||
|
|
||
|
|
||
| class OutageItemDict(Base): |
There was a problem hiding this comment.
This is not actually a dicitonary (unlike RateItemDict, which is).
| class OutageItemDict(Base): | |
| class OutageItem(Base): |
|
|
||
|
|
||
| class Outages(pydantic.RootModel): | ||
| root: list[OutageItemDict] |
There was a problem hiding this comment.
| root: list[OutageItemDict] | |
| root: list[OutageItem] |
| ) | ||
|
|
||
|
|
||
| def load_from_url(url: str | None = None) -> Outages: |
There was a problem hiding this comment.
Do we want the outages file to be loaded separately from the rates file, or should a single call to load_from_... load both rates and outages data? That would require restructuring some things.
| start: datetime | ||
| end: datetime |
There was a problem hiding this comment.
In the Rate model, we use attributes date_from and date_until (and map them to YAML attributes from and until). Any reason not to use the same names here?
There was a problem hiding this comment.
For rate I chose from and until as a shorthand for "effective from" and "effective until". Here start and end felt more aligned with how I would refer to an outage start and end. Ultimately from and until would work fine too and I don't have a strong opinion either way.
| @@ -0,0 +1,5 @@ | |||
| - name: MGHPCC Shutdown 2024 | |||
| information: https://nerc.mghpcc.org/event/mghpcc-annual-power-shutdown-2024/ | |||
There was a problem hiding this comment.
If this is always a URL, I would just call it "url" (and we would validate as such).
No description provided.