Make sure calculation views cannot be used to write or modify rows. #14735
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
mike12345567
reviewed
Oct 9, 2024
| @@ -42,6 +43,11 @@ export async function handleRequest<T extends Operation>( | |||
|
|
|||
| export async function patch(ctx: UserCtx<PatchRowRequest, PatchRowResponse>) { | |||
| const source = await utils.getSource(ctx) | |||
|
|
|||
| if (sdk.views.isView(source) && helpers.views.isCalculationView(source)) { | |||
There was a problem hiding this comment.
We can't delete rows through a calculation view as well right? We should likely add that to this PR too.
mike12345567
approved these changes
Oct 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pretty much what it says in the title. Code and tests to make sure we can't modify data through calculation views.