Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload symbols to Sentry #1063

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Upload symbols to Sentry #1063

merged 7 commits into from
Oct 23, 2023

Conversation

ggordonhall
Copy link
Contributor

@ggordonhall ggordonhall commented Oct 20, 2023 •
edited
Loading

Upload debug symbols to Sentry for MacOS builds so that we get more informative stack-traces where a call-site has been inlined.

@ggordonhall ggordonhall changed the title Upload symbols to sentry Upload symbols to Sentry Oct 20, 2023
@ggordonhall ggordonhall marked this pull request as ready for review October 23, 2023 09:57
rsdy
rsdy approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@rsdy rsdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did anything change in bleep/Cargo.toml? It's a bit hard to see if it's just a reorg from the diff.

@ggordonhall
Copy link
Contributor Author

Did anything change in bleep/Cargo.toml? It's a bit hard to see if it's just a reorg from the diff.

Only one thing. I removed git-version = "0.3.5" from the dev-dependencies. It's already in dependencies.

@ggordonhall ggordonhall merged commit ef89085 into main Oct 23, 2023
9 checks passed
@ggordonhall ggordonhall deleted the gabriel/sentry-upload-debug-symbols branch October 23, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsdy rsdy rsdy approved these changes

@calyptobai calyptobai calyptobai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggordonhall @rsdy @calyptobai