signer: Relax two rules to be warnings only #527
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to accept repeat signature requests and revocations for older states because the signer state update and the CLN state update are not atomic, i.e., the signer commits first, therefore ratchets up, before CLN stores its state, meaning we could potentially replay some prior state due to a preemption and restart inbetween. Relaxing these two should address the majority of our desync issue.
cdecker
force-pushed
the
202441-signer-relax
branch
from
126136c
to
a11761e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to accept repeat signature requests and revocations for older
states because the signer state update and the CLN state update are
not atomic, i.e., the signer commits first, therefore ratchets up,
before CLN stores its state, meaning we could potentially replay some
prior state due to a preemption and restart inbetween. Relaxing these
two should address the majority of our desync issue.