-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2436 document pairing process #525
Draft
nepet
wants to merge
10
commits into
main
Choose a base branch
from
2436-document-pairing-process
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the initial commit of a command line client for gl-client written in rust. A cli in rust will ensure that we reflect changes in existing APIs onto the cli in the future. Signed-off-by: Peter Neuroth <[email protected]>
Removes comments that survived the initial refactoring.
Adds connect to peer method to the node cli Signed-off-by: Peter Neuroth <[email protected]>
Adding listpays requires us to decode the input hex string. Signed-off-by: Peter Neuroth <[email protected]>
Make it more concise. We like to have required arguments as positional arguments and to have flags for optional arguments. Signed-off-by: Peter Neuroth <[email protected]>
Use bitcoin as the default network, we no lonkger what to courage people to use testnet as a default for testing out greenlight Signed-off-by: Peter Neuroth <[email protected]>
The signer needs the device credentials to connect to a stager. Signed-off-by: Peter Neuroth <[email protected]>
Default to Nobody credentials if none are given, this is a convenient way for developers to initialize a pairing session and in line which how the scheduler api behaves. Signed-off-by: Peter Neuroth <[email protected]>
Adds basic pairing support for demonstration purposes. Signed-off-by: Peter Neuroth <[email protected]>
Adds pairing to the command line interface. Signed-off-by: Peter Neuroth <[email protected]>
Is based on #515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some basic documentation about how to use the pairing process.