Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getblocks retry 5 times on "Block not found on disk" before giving up #118

Open
wants to merge 2 commits into
base: new-index
Choose a base branch
from
Open

getblocks retry 5 times on "Block not found on disk" before giving up #118

wants to merge 2 commits into from

Conversation

RCasatta
Copy link
Collaborator

alternative to #117

@RCasatta RCasatta mentioned this pull request Sep 25, 2024
Closed
@shesek
Copy link
Collaborator

shesek commented Sep 29, 2024

The implementation looks good, but perhaps make this part of Daemon::getblocks()?

Daemon is already responsible for retrying on connection errors, so it can fit there. Also we might later want to add limits and sleeping to the connection retry implementation, which could share some constants with this (the two cases are not exactly the same but we could probably still use the same MAX_ATTEMPTS RETRY_WAIT_DURATION for both).

@RCasatta RCasatta mentioned this pull request Sep 30, 2024
Merged
@RCasatta
Copy link
Collaborator Author

The implementation looks good, but perhaps make this part of Daemon::getblocks()?

Done in #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RCasatta @shesek