Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compilation on FreeBSD + clang. #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cbrueffer
Copy link

No description provided.

CC = gcc
CPP ?= g++
CXX ?= $(CPP)
CC ?= gcc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part is useful. Not only when building by clang but also building by gcc-N compiler.

@ch4rr0
Copy link
Collaborator

ch4rr0 commented Jul 27, 2020

I thought I removed the g++ defaults in bug_fixes. I may have forgotten to commit the changes.

@junaruga
Copy link

junaruga commented Jul 27, 2020

@ch4rr0 You are right. I missed the change in master. g++ defaults are not set in Makefile in master.
This repo's Travis has both gcc-N and clang jobs, and it works as expected.

The logic deciding BITS is like this.

bowtie/Makefile

Lines 150 to 152 in 1cc0a45

ifeq (1,$(shell echo __LP64__ | $(CC) -P -E - | tr -d '\n'))
BITS=64
endif

@cbrueffer , maybe you can run the Makefile on FreeBSD without patching, and you can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants