Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the migration status to started #95231

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

valterlorran
Copy link
Contributor

Related to #95156

Proposed Changes

Why are these changes being made?

  • As part of the Post-purchase project, we need to store the state of the migration using the stickers to allow us to better redirect the user back to the flow.
  • For the Post-migration experience, we need to know the status of the migration so we can show the Launchpad with for the migrated sites.

Testing Instructions

  • Apply this diff to your local environment or use Calypso live
  • Start a migration and go through the "Do it for me" flow
  • Once you reach the "Let's us take it from here" step, go to the blog's RC and verify that you have the following events in the Audit Trail panel:
    • add sticker - migration-pending-difm
    • remove sticker - migration-pending-difm
    • add sticker - migration-started-difm

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran requested review from a team October 8, 2024 23:39
@valterlorran valterlorran self-assigned this Oct 8, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 8, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/sticker-migration-start-difm on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~163 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
import-hosted-site-flow       +780 B  (+0.1%)     +163 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants