Remove lane to trim keywords text files longer than 100 chars #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trimming too long keywords client side is the wrong solution to the problem of having keywords that are too long. Because keywords change sporadically, it's much better to edit the localization source on the GlotPress end. And even better long term fix would be to add a character limit to GlotPress. I don't know how to do that know but I'll get in touch with folks that might help with that. See discussion at #1201 (comment)
mokagio
added
the
tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trimming too long keywords client side is the wrong solution to the problem of having keywords that are too long.
Because keywords change sporadically, it's much better to edit the localization source on the GlotPress end.
And even better long term fix would be to add a character limit to GlotPress. I don't know how to do that know but I'll get in touch with folks that might help with that.
See discussion at #1201 (comment)
I'd like to leave this as a draft until the matter is addressed at the root. See pxLjZ-6mD. Just in case I need to trim them again when it comes time for the next submission 🙉
Test
No test required.
Review
Only one developer required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.