Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple options #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add multiple options #9

wants to merge 1 commit into from

Conversation

mhergon
Copy link

@mhergon mhergon commented Jan 27, 2015

Added:

NS_ENUM(ValueLabelPositionType)
|--- ValueLabelLeftInside
|--- ValueLabelLeftOutside

@Property (nonatomic) BOOL drawVerticalGrid;
@Property (nonatomic) BOOL drawHorizontalGrid;

Removed:

NS_ENUM(ValueLabelPositionType)
|--- ValueLabelLeft

Please, search for "// @mhergon Pull request" to see my changes

NS_ENUM(ValueLabelPositionType)
|--- ValueLabelLeftInside
|--- ValueLabelLeftOutside

@Property (nonatomic) BOOL drawVerticalGrid;
@Property (nonatomic) BOOL drawHorizontalGrid;

Removed:
NS_ENUM(ValueLabelPositionType)
|--- ValueLabelLeft

Please, search for "// @mhergon Pull request" to see my changes
@ArthurGuibert
Copy link
Owner

Thanks for the pull request! I'm going to have a look. I just had a quick look and there are a few things that need to change before I consider merging:

  • I'd rather not have the "// @mhergon Pull request" as I can see the diffs on github anyway.
  • I saw that you changed the example. I'm not sure I like it this way... would you mind revert it back as the way it is in the master branch?

@mhergon
Copy link
Author

mhergon commented Jan 30, 2015

Hi,

I'm sorry, you are right. I modified to test with my project and I forget delete these lines.
If you want, I send you the new and modified lines and you change on main branch.
Is that ok?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants