-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_ESP32: Add GPIO driver for ESP32 #28268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs squash into a single commit, but the code changes look good
This looks reasonable, but please rebase on master and retest. We did just merge a big upgrade to ESP-IDF 5.3 which might break it. |
Done merging, tested on my esp32 board. No issue... |
Please rebase on master and squash to one commit, the project does not permit merge commits. |
@tpwrules done |
Well... what @tpwrules really meant was two commits - one per logical subsystem. Sorry, we're not making this stuff up, it's in here: https://ardupilot.org/dev/docs/submitting-patches-back-to-master.html#preparing-commits :-) I've made that split for you and tweaked a commit message and marked this one as "merge on CI pass". Thanks! |
Thank you, newbie here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and "sounds" good to me :)
Sorry I did not notice the additional subsystem change.
Add GPIO driver for ESP32