Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keys(AWSD) for moving ui for research dialog #8857

Closed

Conversation

neoedmund
Copy link

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • [o] I have read the contribution guidelines.
  • [o] I have ensured that my code compiles, if applicable.
  • [o] I have ensured that any new features in this PR function correctly in-game, if applicable.

@Darkness6030
Copy link
Contributor

Nice idea, but...
What about code style?
Did you read the contribution guidelines?

@Anuken
Copy link
Owner

Anuken commented Jul 28, 2023

  • Incorrect formatting. Read the guidelines.
  • This looks broken. KeyDown triggers when the key is first pressed. Panning around by mashing WASD is not acceptable behavior.

@neoedmund
Copy link
Author

  • Incorrect formatting. Read the guidelines.

    • This looks broken. KeyDown triggers when the key is first pressed. Panning around by mashing WASD is not acceptable behavior.

Yeah, I wonder if there is better way than using KeyDown() because it not repeat automatically.

@neoedmund
Copy link
Author

It's not broken, without auto-repeat keys, it's not best, but better than none, useful when using laptop + track pad dragging.
@Anuken as original developer, do you have some improvement advice?
I lied I did not read "contribution guidelines", I don't care about it especially "Style Guidelines".
If any thing make you feel angry or rejection attitude, I'm sorry about it.

@Anuken
Copy link
Owner

Anuken commented Jul 29, 2023

I lied I did not read "contribution guidelines", I don't care about it especially "Style Guidelines".

You should read them first as the template says. If you don't care about the guidelines, just don't open the PR.

@neoedmund neoedmund closed this Jul 29, 2023
@neoedmund
Copy link
Author

Hoho, the game is happy, the conversation is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants