Fix Graph Editor unintentional camera orbit in render view #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeaRe
force-pushed
the
issue-1984-fix-mouse-ui-action-camera-orbit
branch
2 times, most recently
from
79ffeb8
to
d096f94
Compare
This fixes the logic that detects whether the cursor is in the render view. Previously, there were three known issues that are fixed with this change: - The camera would orbit when grabbing the scrollbar located next to the render view. - The camera would orbit when clicking a menu option in the menu dropdown overlapping the render view. - The previous logic to detect the cursor in the render view did not consider that the render view moves up when scrolling. As a result, the camera would still orbit when clicking parts of the Node Property Editor that were previously occupied by the render view. Signed-off-by: Lea Reichardt <[email protected]>
LeaRe
force-pushed
the
issue-1984-fix-mouse-ui-action-camera-orbit
branch
from
d096f94
to
313e36c
Compare
|
This change fixes issue #1984 and another similar issue I noticed during this work (see comment in issue). |
|
This looks really promising, @LeaRe, and I'm CC'ing @lfl-eholthouser for her expertise with this code. |
|
This looks great, @LeaRe! Thanks |
jstone-lucasfilm
approved these changes
Sep 28, 2024
jstone-lucasfilm
merged commit 76bef70
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the logic that detects whether the cursor is in the render view. Previously, there were three known issues that are fixed with this change: