Update Lama Testing Suite #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the default values for Lama nodes to match Pixar Renderman definitions
jstone-lucasfilm
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
This looks good to me, thanks @mkuo-lucasfilm!
Since these updates are so closely related to previous work on MaterialX Lama in 1.39.1, I think it makes sense to include them in the same release, so I'll go ahead and merge this.
jstone-lucasfilm
merged commit cb9b59f
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the default values for Lama nodes to match Pixar Renderman definitions