Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UG #176

Merged
merged 4 commits into from
Apr 14, 2024
Merged

Fix UG #176

merged 4 commits into from
Apr 14, 2024

Conversation

tayziyi
Copy link

@tayziyi tayziyi commented Apr 13, 2024

Fix #109
Fix #145
Fix #146
Fix #156

@simkianseng simkianseng added this to the v1.4 milestone Apr 13, 2024
@simkianseng simkianseng added the type.Bug A bug label Apr 13, 2024
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.21%. Comparing base (91c00f4) to head (5931902).
Report is 22 commits behind head on master.

❗ Current head 5931902 differs from pull request most recent head f90d389. Consider uploading reports for the commit f90d389 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
- Coverage     74.38%   74.21%   -0.17%     
- Complexity      631      632       +1     
============================================
  Files            96       96              
  Lines          2069     2079      +10     
  Branches        229      229              
============================================
+ Hits           1539     1543       +4     
- Misses          472      478       +6     
  Partials         58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@simkianseng simkianseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM just minor formatting suggestions 👍🏻

docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
@YowSiaoKang YowSiaoKang merged commit e5ba74a into AY2324S2-CS2103T-F10-4:master Apr 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment