Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM: Add JWT policy #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

eloycoto
Copy link
Contributor

@eloycoto eloycoto commented Nov 3, 2020

This is a dirty commit POC around implementation of a policy, there are a lot
of hardcoded things, and these are the reason:

-> On a new filter on rust, no way to share metadata. So config should
be hardcoded, PR to change that in upstream is already open.
-> On JWT parsing, there is no way to get the value from Envoy, shared
metadata, etc.. so need to work on decode that, all the libraries are
using SSL libs, and WASM cannot be started if enabled.

Signed-off-by: Eloy Coto [email protected]

@eloycoto eloycoto requested a review from a team as a code owner November 3, 2020 16:29
This is a dirty commit POC around implementation of a policy, there are a lot
of hardcoded things, and these are the reason:

-> On a new filter on rust, no way to share metadata. So config should
be hardcoded, PR to change that in upstream is already open.
-> On JWT parsing, there is no way to get the value from Envoy, shared
metadata, etc.. so need to work on decode that, all the libraries are
using SSL libs, and WASM cannot be started if enabled.

Signed-off-by: Eloy Coto <[email protected]>
@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #30 (22e5e22) into master (0ba087a) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #30      +/-   ##
=========================================
- Coverage    0.25%   0.21%   -0.04%     
=========================================
  Files          11      12       +1     
  Lines         387     455      +68     
=========================================
  Hits            1       1              
- Misses        386     454      +68     
Impacted Files Coverage Δ
src/oidc.rs 0.00% <0.00%> (ø)
src/service.rs 0.00% <ø> (ø)
wasm_filter/src/config.rs 0.00% <ø> (ø)
wasm_filter/src/jwt.rs 0.00% <0.00%> (ø)
wasm_filter/src/lib.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba087a...9fe76d4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants