-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper ZK treatment in plonky2
#1625
base: main
Are you sure you want to change the base?
Conversation
plonky2/src/fri/oracle.rs
Outdated
let last_poly = if is_zk && idx == 0 { | ||
polynomials.len() - 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a one-liner for the -2
This PR aims at addressing #1625, based on this note https://eprint.iacr.org/2024/1037.pdf .
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a first pass and mostly pointed out nits.
I guess this is what the note meant (Protocol 2, isn't it?), because why doing two proofs if you can batch them and compute only one proof? And batching them is like doing FRI for the large poly. |
@LindaGuiga I'm opening a draft PR to be able to comment on the code