-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy fails when there are no existing events in log #182
Comments
Hi @lynchem, a similar issue was reported here: #177 (comment) Would you be interested to try a version of this plugin that I have been using successfully for many months now. To test your theory, I just deployed a project that hasn't had an update in at least 3 months. I have the plugin here, I think you should be able to install it with npm i @activitree/mup-aws-beanstalk@https://github.com/activitree/mup-aws-beanstalk.git The version is 0.9.5 This package has all libraries updates to date. |
Hey thanks @paulincai . Yes, I work with @tcastelli 😆 We were trying to find the most relevant issue but I think the other one was something else where this issue also cropped up. We don't have any way to test your package right now, save creating a new app/environment. Unless there's a way to purge the event log? It would be great to get a PR open to the original too and hopefully zodern can take a look and get it updated. |
i'm suffering the same, after diving through |
If you try to deploy to an app that hasn't been deployed for a month it quite possibly will have no logs and a couple of places in this lib will fail. I'm not sure exactly what the EB retention policy / cap is on events logs but my observations says it's 1 month / 100 records - but there's no where to configure this and who knows if they'll reduce it further in the future making this even more noticeable.
The two in question are:
return Events[0].EventDate;
ingetLastEvent
return new Date(Events[0].EventDate);
inshowEvents
This all seems to be fixed in #178
If that code is good could we try release an rc to test it out @zodern ?
The text was updated successfully, but these errors were encountered: