Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change tests #442

Open
szuecs opened this issue Oct 6, 2021 · 0 comments
Open

change tests #442

szuecs opened this issue Oct 6, 2021 · 0 comments

Comments

@szuecs
Copy link
Member

szuecs commented Oct 6, 2021

In https://github.com/zalando/skipper/blob/master/dataclients/kubernetes/ we use golden files to validate that an input of an Ingress or RouteGroup (both .yaml files) will output the right .eskip, .log, .., including overriding configuration for single tests via .kube files. This needs a bit of test infra in code, but is worth all the time spend there.
We should do the same for this controller with ingress/routegroup (yaml) as input and CF .json files as output.

To start to gather CF files for given ingress/routegroups we could dump the CF files to debug logs and use a test cluster to create files for different configurations (controller flags) and input files (ingress/routegroup with/without annotations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant