-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top list `generator: react-fullstack is not a generator #524
Comments
No, that's why we have a blacklist. So many user publish junk without even changing the repo URL. You can add it to: https://github.com/yeoman/yeoman.io/blob/master/app/blacklist.json And anything else you find that shouldn't be in the list. |
Already create a PR #484 but @SBoudrias closed :-( |
Oh, I didn't see that issue. I think it's because we previously just tried to get the URL from the github repo instead of the npm package. This should have been fixed in https://github.com/yeoman/yeoman-generator-list, but I think @SBoudrias reversed the deploy of that. Not totally sure though. |
Nice :) No questions, no prompt just copy https://github.com/kriasoft/react-starter-kit/blob/yeoman-generator/app/index.js#L23 |
@zckrs I don't agree. It might be simple, but it's still better than having to manually get the starter kit. |
Ok I understand :-/ sorry. Sort generator only by github stars is not enough. |
Keeping open as we're going to somehow fix that generator being at the top. |
Although I wouldn't agree upon blacklisting, it would be cool if it wouldn't be at the top indeed. Maybe just convincing the author to have a separated repo for the generator is enough. I mean, having it in another repo makes the generator more visible for users (and contributors) too. |
Please read my comment: #524 (comment) This is already fixed, just needs to be correctly deployed. |
I do not see a commit that replaced the github link by link npm. |
closing since its not at the top anymore |
ugh. just kidding it is still at the top |
ok closing again as its referenced in the generator page change issue |
#484
If https://github.com/twbs/bootstrap create a branch 'yeoman-generator' who just copy files in new directory and published on NPM.
Should we keep at first position in generator list ???
The text was updated successfully, but these errors were encountered: