Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top list `generator: react-fullstack is not a generator #524

Closed
zckrs opened this issue Sep 1, 2015 · 13 comments
Closed

Top list `generator: react-fullstack is not a generator #524

zckrs opened this issue Sep 1, 2015 · 13 comments

Comments

@zckrs
Copy link
Member

zckrs commented Sep 1, 2015

  • The master branch is not a Yeoman generator but a boilerplate
  • If you check the code source the repository use yeoman only to copy boilerplate (no prompt)

#484

If https://github.com/twbs/bootstrap create a branch 'yeoman-generator' who just copy files in new directory and published on NPM.
Should we keep at first position in generator list ???

@sindresorhus
Copy link
Member

No, that's why we have a blacklist. So many user publish junk without even changing the repo URL.

You can add it to: https://github.com/yeoman/yeoman.io/blob/master/app/blacklist.json And anything else you find that shouldn't be in the list.

@zckrs
Copy link
Member Author

zckrs commented Sep 1, 2015

Already create a PR #484 but @SBoudrias closed :-(

@sindresorhus
Copy link
Member

Oh, I didn't see that issue. I think it's because we previously just tried to get the URL from the github repo instead of the npm package. This should have been fixed in https://github.com/yeoman/yeoman-generator-list, but I think @SBoudrias reversed the deploy of that. Not totally sure though.

@zckrs
Copy link
Member Author

zckrs commented Sep 1, 2015

Nice :)
But even if the url is recovered from github repo, generator-react-fullstack is a con IMO.

hiha

No questions, no prompt just copy https://github.com/kriasoft/react-starter-kit/blob/yeoman-generator/app/index.js#L23

@sindresorhus
Copy link
Member

@zckrs I don't agree. It might be simple, but it's still better than having to manually get the starter kit.

@zckrs
Copy link
Member Author

zckrs commented Sep 1, 2015

Ok I understand :-/ sorry.

Sort generator only by github stars is not enough.
Im disappointed when I install this top generator.

#459 (comment)

@zckrs zckrs closed this as completed Sep 1, 2015
@sindresorhus sindresorhus reopened this Sep 1, 2015
@sindresorhus
Copy link
Member

Keeping open as we're going to somehow fix that generator being at the top.

@arthurvr
Copy link
Member

arthurvr commented Sep 1, 2015

Although I wouldn't agree upon blacklisting, it would be cool if it wouldn't be at the top indeed. Maybe just convincing the author to have a separated repo for the generator is enough. I mean, having it in another repo makes the generator more visible for users (and contributors) too.

@sindresorhus
Copy link
Member

Please read my comment: #524 (comment) This is already fixed, just needs to be correctly deployed.

@zckrs
Copy link
Member Author

zckrs commented Sep 1, 2015

I do not see a commit that replaced the github link by link npm.

@eddiemonge
Copy link
Member

closing since its not at the top anymore

@eddiemonge
Copy link
Member

ugh. just kidding it is still at the top

@eddiemonge eddiemonge reopened this Dec 11, 2015
@eddiemonge eddiemonge changed the title Top list generator: react-fulltack is not a generator Top list `generator: react-fullstack is not a generator Dec 11, 2015
@eddiemonge
Copy link
Member

ok closing again as its referenced in the generator page change issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants