From dc80abbd7d8576b4dc3d4f090dcf8084dd1e2981 Mon Sep 17 00:00:00 2001 From: Ian Maia Date: Tue, 20 Feb 2024 15:36:45 +0100 Subject: [PATCH 1/2] Add Dangermattic configuration --- .github/workflows/run-danger.yml | 11 +++++ Dangerfile | 15 +++++++ Gemfile | 2 +- Gemfile.lock | 72 ++++++++++++++++++++++++++++++-- 4 files changed, 95 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/run-danger.yml create mode 100644 Dangerfile diff --git a/.github/workflows/run-danger.yml b/.github/workflows/run-danger.yml new file mode 100644 index 0000000..0d0115e --- /dev/null +++ b/.github/workflows/run-danger.yml @@ -0,0 +1,11 @@ +name: ☢️ Danger + +on: + pull_request: + types: [opened, reopened, ready_for_review, synchronize] + +jobs: + dangermattic: + uses: Automattic/dangermattic/.github/workflows/reusable-run-danger.yml@v1.0.0 + secrets: + github-token: ${{ secrets.DANGERMATTIC_GITHUB_TOKEN }} diff --git a/Dangerfile b/Dangerfile new file mode 100644 index 0000000..0db4631 --- /dev/null +++ b/Dangerfile @@ -0,0 +1,15 @@ +# frozen_string_literal: true + +github.dismiss_out_of_range_messages + +# `files: []` forces rubocop to scan all files, not just the ones modified in the PR +rubocop.lint(files: [], force_exclusion: true, inline_comment: true, fail_on_inline_comment: true, include_cop_names: true) + +manifest_pr_checker.check_all_manifest_lock_updated + +podfile_checker.check_podfile_does_not_have_branch_references + +pr_size_checker.check_diff_size( + max_size: 300, + type: :insertions +) diff --git a/Gemfile b/Gemfile index d9b89b1..55f85b1 100644 --- a/Gemfile +++ b/Gemfile @@ -4,5 +4,5 @@ source 'https://rubygems.org' gem 'cocoapods', '~> 1.11' gem 'cocoapods-check', '~> 1.1' +gem 'danger-dangermattic', '~> 1.0' gem 'fastlane', '~> 2.189' -gem 'rubocop', '~> 1.18' diff --git a/Gemfile.lock b/Gemfile.lock index 969fd9e..ee03f00 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -41,6 +41,10 @@ GEM base64 (0.2.0) bigdecimal (3.1.5) claide (1.1.0) + claide-plugins (0.9.2) + cork + nap + open4 (~> 1.3) cocoapods (1.14.3) addressable (~> 2.8) claide (>= 1.0.2, < 2.0) @@ -86,6 +90,44 @@ GEM highline (~> 2.0.0) concurrent-ruby (1.2.2) connection_pool (2.4.1) + cork (0.3.0) + colored2 (~> 3.1) + danger (9.4.3) + claide (~> 1.0) + claide-plugins (>= 0.9.2) + colored2 (~> 3.1) + cork (~> 0.1) + faraday (>= 0.9.0, < 3.0) + faraday-http-cache (~> 2.0) + git (~> 1.13) + kramdown (~> 2.3) + kramdown-parser-gfm (~> 1.0) + no_proxy_fix + octokit (>= 4.0) + terminal-table (>= 1, < 4) + danger-dangermattic (1.0.0) + danger (~> 9.4) + danger-junit (~> 1.0) + danger-plugin-api (~> 1.0) + danger-rubocop (~> 0.12) + danger-swiftlint (~> 0.35) + danger-xcode_summary (~> 1.0) + rubocop (~> 1.60) + danger-junit (1.0.2) + danger (> 2.0) + ox (~> 2.0) + danger-plugin-api (1.0.0) + danger (> 2.0) + danger-rubocop (0.12.0) + danger + rubocop (~> 1.0) + danger-swiftlint (0.35.0) + danger + rake (> 10) + thor (~> 1.0.0) + danger-xcode_summary (1.3.0) + danger-plugin-api (~> 1.0) + xcresult (~> 0.2) declarative (0.0.20) digest-crc (0.6.4) rake (>= 12.0.0, < 14.0.0) @@ -116,6 +158,8 @@ GEM faraday-em_http (1.0.0) faraday-em_synchrony (1.0.0) faraday-excon (1.1.0) + faraday-http-cache (2.5.1) + faraday (>= 0.8) faraday-httpclient (1.0.1) faraday-net_http (1.0.1) faraday-net_http_persistent (1.2.0) @@ -166,6 +210,9 @@ GEM fourflusher (2.3.1) fuzzy_match (2.0.4) gh_inspector (1.1.3) + git (1.19.1) + addressable (~> 2.8) + rchardet (~> 1.8) google-apis-androidpublisher_v3 (0.10.0) google-apis-core (>= 0.4, < 2.a) google-apis-core (0.4.1) @@ -213,6 +260,10 @@ GEM jmespath (1.6.2) json (2.7.1) jwt (2.2.3) + kramdown (2.4.0) + rexml + kramdown-parser-gfm (1.1.0) + kramdown (~> 2.0) language_server-protocol (3.17.0.3) memoist (0.16.2) mini_magick (4.11.0) @@ -226,9 +277,16 @@ GEM nap (1.1.0) naturally (2.2.1) netrc (0.11.0) + no_proxy_fix (0.1.2) + octokit (8.1.0) + base64 + faraday (>= 1, < 3) + sawyer (~> 0.9) + open4 (1.3.4) os (1.1.1) + ox (2.14.17) parallel (1.24.0) - parser (3.3.0.2) + parser (3.3.0.5) ast (~> 2.4.1) racc plist (3.6.0) @@ -236,6 +294,7 @@ GEM racc (1.7.3) rainbow (3.1.1) rake (13.0.6) + rchardet (1.8.0) regexp_parser (2.9.0) representable (3.1.1) declarative (< 0.1.0) @@ -244,11 +303,11 @@ GEM retriable (3.1.2) rexml (3.2.6) rouge (2.0.7) - rubocop (1.59.0) + rubocop (1.60.2) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) - parser (>= 3.2.2.4) + parser (>= 3.3.0.2) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) @@ -261,6 +320,9 @@ GEM ruby-progressbar (1.13.0) ruby2_keywords (0.0.5) rubyzip (2.3.2) + sawyer (0.9.2) + addressable (>= 2.3.5) + faraday (>= 0.17.3, < 3) security (0.1.3) signet (0.15.0) addressable (~> 2.3) @@ -272,6 +334,7 @@ GEM naturally terminal-notifier (2.0.0) terminal-table (1.6.0) + thor (1.0.1) trailblazer-option (0.1.1) tty-cursor (0.7.1) tty-screen (0.8.1) @@ -299,6 +362,7 @@ GEM rouge (~> 2.0.7) xcpretty-travis-formatter (1.0.1) xcpretty (~> 0.2, >= 0.0.7) + xcresult (0.2.1) PLATFORMS ruby @@ -306,8 +370,8 @@ PLATFORMS DEPENDENCIES cocoapods (~> 1.11) cocoapods-check (~> 1.1) + danger-dangermattic (~> 1.0) fastlane (~> 2.189) - rubocop (~> 1.18) BUNDLED WITH 2.3.22 From 5af448e6146e76bb1f9cdec54ee88da6868dda8e Mon Sep 17 00:00:00 2001 From: Ian Maia Date: Tue, 20 Feb 2024 16:06:01 +0100 Subject: [PATCH 2/2] Remove Podfile branch references check --- Dangerfile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Dangerfile b/Dangerfile index 0db4631..85dc421 100644 --- a/Dangerfile +++ b/Dangerfile @@ -7,8 +7,6 @@ rubocop.lint(files: [], force_exclusion: true, inline_comment: true, fail_on_inl manifest_pr_checker.check_all_manifest_lock_updated -podfile_checker.check_podfile_does_not_have_branch_references - pr_size_checker.check_diff_size( max_size: 300, type: :insertions