Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the separation of URL construction & execution concerns #85

Open
ghost opened this issue Feb 5, 2019 · 0 comments
Open

Improve the separation of URL construction & execution concerns #85

ghost opened this issue Feb 5, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Feb 5, 2019

Expected behavior

Request construction & execution should be separate concerns.

Actual behavior

As discussed in #78, responsibilities for request construction are shared between both ServiceRemoteWordPressComREST & WordPressComRestApi. WordPressComRestApi currently executes requests.

We might benefit from the approach taken by our Woo counterparts.

Steps to reproduce the behavior

N/A

WordPressKit Environment

All devices & versions of WordPressKit, Xcode & iOS.

  • WordPressKit Version [e.g. 22] : all versions
  • OS: [e.g. iOS 12.1.3 (16D40)] : all versions
  • Device: [e.g. iPhone XS] : all devices
  • Xcode Version: [e.g. Xcode 10.1 (10B61)] : all versions
Additional Context

N/A
@ghost ghost added the enhancement New feature or request label Feb 5, 2019
@ghost ghost changed the title Better separate the concerns of URL construction & execution Improve the separation of URL construction & execution concerns Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants