New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule : Dimens values shouldn't be hardcoded in xml attributes #5

Open

jd-alexander opened this issue Jun 17, 2020 · 0 comments

Labels

Contributor

jd-alexander commented Jun 17, 2020

Expected behavior

Dimension values shouldn't be hardcoded in XML files. They should be placed in the dimens resources (dimens.xml).

Actual behavior

You can place the dimens values within XML files and there are no issues. The build still passes locally and on CI.

Steps to reproduce the behavior

Add a raw dimens value to an XML attribute.
Notice that when you run the lintCheck it doesn't fail.

jd-alexander added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment