-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js 4.x "let basic support" is "Yes" wrongly. It must be "Error" #52
Comments
like the error says, you have to use strict mode[1] for block scoped declarations. they work fine in node 4.9 [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode |
@devsnek I know. You are saying about "basic support (strict mode)" entry. It's "yes" in the table correctly. |
let
basic support?
cc/ @williamkapke |
Sry, I've been away for awhile. @mysticatea I see what you're talking about. There are 2 reason why it's like this: Mimicking how the Kangax test works: https://github.com/williamkapke/node-compat-table/blob/gh-pages/test.js#L82-L83 It first tries without strict- and then, if failure, tries WITH strict. Being Green Adding An indicator that As always- a PR is welcome! |
@williamkapke In that case, I have a question. Why do you separate basic support and basic support (strict mode)? The separated entries are confusing. |
Ahh... now I fully understand what you're asking about. Sorry I didn't catch that. Since they're broken out- yes, it seems we could remove the strict fallback test (for node.green's purposes). It's easy enough to remove-- but I wonder how much it will change other test results 🤔 Will need to try it and see! |
Ok. strict mode fallback has been removed. There were many changes. See: Anything seem like a bad side effect? |
Class syntax seems to become And some entries are using class syntax in their test functions. E.g., Generators: shorthand generator methods, classes. Those will become |
let
basic support on Node.js 4.x seemsyes
, however, I believe it throws syntax error.The text was updated successfully, but these errors were encountered: