-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG Missing Git Ignore #106
Comments
Hey @codingwithmanny @tmm, may I be assigned this issue? |
@codingwithmanny is the issue assigned to somebody already? |
Hi @FaybianB and @dicethedev just need @jxom or @tmm to assign it. I wish I was a maintainer on this repo, but just a contributor 😂 |
No problem |
First PR wins. |
I made a PR - #111 |
Well, I lost the PR race (nice quickness @dicethedev) but I still would like to submit a solution. It seems like However, I haven't gotten |
Hey @FaybianB, not sure if this will help but the way I was testing it to try and figure out was trying was running the script directory in the # FROM: ./
pnpm build;
cd ./create-vocs; Then run the built binary in the newly created # FROM: ./create-vocs
# Modify permissions
chmod +x ./_lib/bin.js;
# Run binary
./_lib/bin.js;
# [Expected Output]:
# ┌ Welcome to Vocs!
# │
# ◇ Enter the name of your project
# │ tmp
# │
# ◆ Project successfully scaffolded in /path/to/vocs/create-vocs/tmp!
# │
# │ Next steps:
# │
# ◇ 1. cd ./tmp - Navigate to project
# │
# ◇ 2. npm install - Install dependencies
# │
# ◇ 3. npm run dev - Start dev server
# │
# ◇ 4. Head to http://localhost:5173
# │
# └ Happy documenting! 📝 This will create that new # FROM: ./create-vocs
tree tmp -a;
# [Expected Output]:
# tmp
# ├── .gitignore <------ HUH????
# ├── README.md
# ├── docs
# │ └── pages
# │ ├── example.mdx
# │ ├── getting-started.mdx
# │ └── index.mdx
# ├── package.json
# ├── tsconfig.json
# └── vocs.config.ts |
How did you test that this worked? |
@codingwithmanny You know, following your testing method works for me and I too see the |
@FaybianB it's something to do with the bundling that goes to npm packages. If you create a new folder and install mkdir test-create-vocs;
cd test-create-vocs;
pnpm init;
pnpm add create-vocs; Then tree the directory and you'll see that the # FROM: test-create-vocs;
tree node_modules/create-vocs/templates/default -a;
# [Expected Output]:
# node_modules/create-vocs/templates/default
# ├── README.md
# ├── docs
# │ └── pages
# │ ├── example.mdx
# │ ├── getting-started.mdx
# │ └── index.mdx
# ├── package.json
# ├── tsconfig.json
# └── vocs.config.ts I suspect it has to do with a script in the Hopefully that would help with a direction. |
Fixes the issue of when running `npm pack` which excludes `.gitignore`. BREAKING CHANGE: No Closes: wevm#106
Following the conventions of `init.ts` L33 which replaces dot files starting with _ this prepack temporarily renames gitignore to fit within the requirements BREAKING CHANGE: No Closes: wevm#106
This doesn't work BREAKING CHANGE: No Closes: wevm#106
Ended up figuring it out @FaybianB see PR |
@codingwithmanny I was figuring out the fix, but just saw that you've already made a PR. Happy to see a solution. |
Context
Missing
.gitignore
when creating a new project.Steps To Reproduce
Then take a look at the full directory.
Solution
Include the
.gitignore
with./create-vocs/templates/default/.gitignore
The text was updated successfully, but these errors were encountered: