Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL tests use plain JSON #4

Open
ryansb opened this issue Oct 13, 2015 · 2 comments
Open

PostgreSQL tests use plain JSON #4

ryansb opened this issue Oct 13, 2015 · 2 comments

Comments

@ryansb
Copy link

ryansb commented Oct 13, 2015

In the tests you use the JSON type, while for a "real" environment that was performance-sensitive it's likely that JSONB would be used instead. Optionally, you could also add a GIN on the structure field which would likely improve the relation matching performance.

@weinberger
Copy link
Owner

I will rerun the tests with JSON and make an update on the blog post. But adding an index to the structure field would a misleading optimization. All request except the aggregation already goes to indexed fields. The aggregation is defined as an ad hoc query.

@ryansb
Copy link
Author

ryansb commented Oct 19, 2015

That's fair, feel free to skip the indexing. Even without the index, JSONB should make a performance difference. Thank you for considering the change, and thanks for publishing these benchmarks. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants