Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing versioning of Python package versus Core WebUI #14

Open
kvbik opened this issue Nov 30, 2023 · 1 comment
Open

Confusing versioning of Python package versus Core WebUI #14

kvbik opened this issue Nov 30, 2023 · 1 comment

Comments

@kvbik
Copy link

kvbik commented Nov 30, 2023

Starting with 10ebb25 there was an increment from v2.4.1 to v2.4.2, but the Core WebUI used was still v2.4.1, couple commits later the Core was incremented also, but so was the python wrapper to v2.4.3.

I am no expert on building wrappers and semantic version of those, but I find it rather confusing. I understand the need of iterating the Python wrapper over the same Core version. So maybe what was done before, eg.: v2.4.2.X was bit better?

UPDATE: ok, semantic versioning discourages [1] from keeping the same version number for wrapper and the core library. But maybe in our case here it is not that bad - if they don't differe in one number of the scheme CORE.MAJOR.MINOR.PATCH.

[1] semver/semver#352 (comment)

@hassandraga
Copy link
Member

Thank you for suggesting that. This is an important point. We tried to standardize all wrappers (Versions, dealing with binaries...), but we found out that each wrapper has different needs, so we decided to let each wrapper follow its path. It's not the final decision, but it's going well for now.

should never pin the FooJS version to the Foo version
[1] semver/semver#352 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants