Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoTrackGenerator.applyConstraints success is unclear #97

Open
youennf opened this issue Jan 29, 2024 · 0 comments
Open

VideoTrackGenerator.applyConstraints success is unclear #97

youennf opened this issue Jan 29, 2024 · 0 comments

Comments

@youennf
Copy link
Contributor

youennf commented Jan 29, 2024

It is unclear when applyConstraints is expected to succeed.
The spec seems to indicate that any width/height/frameRate that are in the capabilities range should be good.
But the capabilities is the max, which would indicate that upsampling might be required if the width constraint is greater than the last enqueued video frame.

Looking at what Chrome is doing, it seems that:

  • When there is no frame written, applyConstraints is always rejecting
  • applyConstraints may reject if width/height is above the last enqueued frame (even though capabilities might be bigger).
  • settings are tied to the last video frame size so it might change even if applyConstraints was called.

My understanding of what we want is a way to downsample resolution and frame rate.
Maybe we should make it clear this goal in the spec, if we agree on this.

It would be good to provide some kind of algorithms or/and provide an extensive test suite in this area.
Without this, it might be difficult to get interop.

@youennf youennf changed the title Support of VideoTrackGenerator.applyConstraints success is unclear VideoTrackGenerator.applyConstraints success is unclear Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant