Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig change doesn't trigger a dev server reload after vite.config.ts change #18538

Closed
7 tasks done
djibarian opened this issue Oct 31, 2024 · 2 comments
Closed
7 tasks done
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)

Comments

@djibarian
Copy link

Describe the bug

When you make changes to tsconfig.json the dev server reloads fine:

10:47:28 [vite] changed tsconfig file detected: [...]/tsconfig.json - Clearing cache and forcing full-reload to ensure TypeScript is compiled with updated config values.

But if you make changes to vite.config.ts and then to tsconfig, the server doesn't reload anymore:

10:47:41 [vite] vite.config.ts changed, restarting server...
[sentry-vite-plugin] Info: Using environment variables configured in ".env.sentry-build-plugin".
10:47:41 [vite] server restarted.

Making a change to tsconfig now doesn't trigger a reload anymore.

Reproduction

can't be done in vite.new

Steps to reproduce

See description.

System Info

needed?

Used Package Manager

npm

Logs

No response

Validations

@bluwy
Copy link
Member

bluwy commented Oct 31, 2024

Is it fixed with the Vite 6 beta? We recently merged a refactor that should likely not cause this behaviour anymore.

@sapphi-red
Copy link
Member

I was able to reproduce it on Stackblitz with Vite 5.4.11 and I confirmed that this is fixed in Vite 6 beta.

@sapphi-red sapphi-red added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

No branches or pull requests

3 participants